Suppress errors related to legacy client in code generator #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Conflicts: plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/Configuration.java
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
Signed-off-by: Shahrzad <[email protected]>
|
Thanks @shahrzadav. Could you please checkout the build errors before I review the PR? Thanks. |
Conflicts: plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/Configuration.java plugins/de.cognicrypt.crysl.handler/src/main/java/de/cognicrypt/crysl/reader/CrySLModelReader.java plugins/de.cognicrypt.staticanalyzer/.classpath
…ogniCrypt.git into iss193-FilterResult Conflicts: plugins/de.cognicrypt.staticanalyzer/.classpath
|
Thanks @kruegers , it is without build errors now. please review it. |
Conflicts: plugins/de.cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/Configuration.java plugins/de.cognicrypt.crysl.handler/src/main/java/de/cognicrypt/crysl/reader/CrySLModelReader.java plugins/de.cognicrypt.staticanalyzer/.classpath
Signed-off-by: Shahrzad <[email protected]>
shahrzadav
force-pushed
the
iss193-FilterResult
branch
from
dbc87ff to
07de860
Compare
kruegers
requested changes
May 7, 2020
There was a problem hiding this comment.
I aborted my review halfway through because the PR contains many reversions to extensions and bugfixes we have implemented in the last few months. Please fix the PR first before I review again. Do however implement the feedback I have already given as well, please. Thanks.
...cognicrypt.codegenerator/src/main/java/de/cognicrypt/codegenerator/wizard/Configuration.java
Show resolved
Hide resolved
...ator/src/main/java/de/cognicrypt/codegenerator/wizard/beginner/BeginnerTaskQuestionPage.java
Outdated
Show resolved
Hide resolved
plugins/de.cognicrypt.codegenerator/src/main/resources/TaskDesc/SecureCommunication.json
Show resolved
Hide resolved
plugins/de.cognicrypt.core/src/de/cognicrypt/core/Constants.java
Outdated
Show resolved
Hide resolved
...nicrypt.crysl.handler/src/main/java/de/cognicrypt/crysl/reader/StateMachineGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ns/de.cognicrypt.crysl.handler/src/test/java/de/cognicrypt/cryslhandler/SMGBuilderTests.java
Outdated
Show resolved
Hide resolved
|
Hey @rakshitkr , Once @shahrzadav has fixed the issues with this PR, please both test it on your machine and review the code here on Github. Thanks. |
Signed-off-by: Shahrzad <[email protected]>
…ogniCrypt.git into iss193-FilterResult Conflicts: plugins/de.cognicrypt.staticanalyzer/src/de/cognicrypt/staticanalyzer/StaticAnalyzerPreferences.java
Signed-off-by: Shahrzad <[email protected]>
rakshitkr
reviewed
May 24, 2020
|
assigned @schlichtig. |
Signed-off-by: Shahrzad <[email protected]>
rakshitkr
suggested changes
Jun 1, 2020
rakshitkr
reviewed
Jun 1, 2020
| } | ||
| } | ||
| } catch (ParseException | IOException e2) { | ||
| e2.printStackTrace(); |
There was a problem hiding this comment.
Use Activator.getDefault().logError() here instead
Signed-off-by: Shahrzad <[email protected]>
|
Have tested the changes on my machine. Everything is working. |
shahrzadav
commented
Jun 5, 2020
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/> | ||
| <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"> | ||
| <attributes> | ||
| <attribute name="maven.pomderived" value="true"/> |
There was a problem hiding this comment.
what is this, should I add or not?
shahrzadav
commented
Jun 5, 2020
| @@ -21,6 +21,7 @@ Require-Bundle: org.eclipse.ui, | |||
| Bundle-RequiredExecutionEnvironment: JavaSE-1.8 | |||
| Bundle-ActivationPolicy: lazy | |||
| Bundle-ClassPath: ., | |||
| resources/ | |||
| resources/json-simple.jar | |||
There was a problem hiding this comment.
did not add this either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user selects Legacy client in code generator in secure communication task, errors related to this constraint will be suppressed, if and only if the checkbox related to this in preference page is also selected.
Fixes #193
Type of change
How Has This Been Tested?
It has been tested in runtime.
Test Configuration:
Checklist: